[ixpmanager] IRRDB error handling

[Nick Hilliard]

yep that looks correct.  Committed as:

https://github.com/inex/IXP-Manager/commit/80c398690b4b73e03c86f83966628889703c77f5

+ Yann has ensured that this is fixed in -dev

Nick


Pete Ashdown wrote on 05/05/2021 00:19:
>
> I ran across this problem in UpdatePrefixDb.php as well, and made a 
> similar patch.  I hope I didn't assume too much:
>
> *** UpdatePrefixDb.php-orig    2021-05-04 17:16:41.247198103 -0600
> --- UpdatePrefixDb.php    2021-05-04 15:58:40.512741630 -0600
> ***************
> *** 49,55 ****
>       public function update(): array {
>
>           foreach( $this->protocols() as $protocol ) {
> !             if( $this->customer()->isRouteServerClient( $protocol ) 
> && $this->customer()->isIrrdbFiltered() && ) {
>                   $this->bgpq3()->setSources( 
> $this->customer()->getIRRDB()->getSource() );
>
>                   $this->startTimer();
> --- 49,55 ----
>       public function update(): array {
>
>           foreach( $this->protocols() as $protocol ) {
> !             if( $this->customer()->isRouteServerClient( $protocol ) 
> && $this->customer()->isIrrdbFiltered() && 
> $this->customer()->getIRRDB() ) {
>                   $this->bgpq3()->setSources( 
> $this->customer()->getIRRDB()->getSource() );
>
>                   $this->startTimer();
>
>
> On 3/14/21 1:11 PM, Nick Hilliard wrote:
>> Pete Ashdown wrote on 14/03/2021 18:53:
>>> Had a customer who entered their AS macros wrong, and as a result, 
>>> they blocked everyone below them alphabetically from receiving IRRDB 
>>> updates.  It would be good if the update would continue over these 
>>> kind of errors.  Here is the output from the crash:
>>
>> Hi Pete,
>>
>> This should already be fixed in master:
>>
>>> https://github.com/inex/IXP-Manager/commit/d67b493d30c6483ded4d265d7d51c30924a26739 
>>>
>>
>> Nick
>>
>
>
> _______________________________________________
> INEX IXP Manager mailing list
> ixpmanager at inex.ie
> Unsubscribe or change options here: https://www.inex.ie/mailman/listinfo/ixpmanager

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://www.inex.ie/pipermail/ixpmanager/attachments/20210610/d32b5d22/attachment.htm>