<html theme="default-light" iconset="color"><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head><body text="#485663">yep that looks correct.  Committed as:<br>
<br>
<a class="moz-txt-link-freetext" href="https://github.com/inex/IXP-Manager/commit/80c398690b4b73e03c86f83966628889703c77f5">https://github.com/inex/IXP-Manager/commit/80c398690b4b73e03c86f83966628889703c77f5</a><br>
<br>
+ Yann has ensured that this is fixed in -dev<br>
<br>
Nick<br>
<br>
<br>
<span>Pete Ashdown wrote on 05/05/2021 00:19:</span><br>
<blockquote type="cite" 
cite="mid:f9f8efe9-1773-c4ac-cd42-78a35b53ed14@xmission.com">
  <meta http-equiv="content-type" content="text/html; charset=utf-8">

  
  
    
  <p>I ran across this problem in UpdatePrefixDb.php as well, and made
      a similar patch.  I hope I didn't assume too much:</p>

    
  <p><font face="Courier New, Courier, monospace">***
        UpdatePrefixDb.php-orig    2021-05-04 17:16:41.247198103 -0600<br>
        --- UpdatePrefixDb.php    2021-05-04 15:58:40.512741630 -0600<br>
        ***************<br>
        *** 49,55 ****<br>
              public function update(): array {<br>
        <br>
                  foreach( $this->protocols() as $protocol ) {<br>
        !             if( $this->customer()->isRouteServerClient(
        $protocol ) &&
        $this->customer()->isIrrdbFiltered() && ) {<br>
                          $this->bgpq3()->setSources(
        $this->customer()->getIRRDB()->getSource() );<br>
        <br>
                          $this->startTimer();<br>
        --- 49,55 ----<br>
              public function update(): array {<br>
        <br>
                  foreach( $this->protocols() as $protocol ) {<br>
        !             if( $this->customer()->isRouteServerClient(
        $protocol ) &&
        $this->customer()->isIrrdbFiltered() &&
        $this->customer()->getIRRDB() ) {<br>
                          $this->bgpq3()->setSources(
        $this->customer()->getIRRDB()->getSource() );<br>
        <br>
                          $this->startTimer();</font><br>
    </p>

    <br>

    On 3/14/21 1:11 PM, Nick Hilliard wrote:<br>

    
  <blockquote type="cite">Pete Ashdown wrote on 14/03/2021 18:53:<br>
      <blockquote type="cite">Had a customer who entered their AS macros
        wrong, and as a result, they blocked everyone below them
        alphabetically from receiving IRRDB updates.  It would be good
        if the update would continue over these kind of errors.  Here is
        the output from the crash:<br></blockquote>
      <br>
      Hi Pete,<br>
      <br>
      This should already be fixed in master:<br>
      <br>
      <blockquote type="cite"><a class="moz-txt-link-freetext" 
href="https://github.com/inex/IXP-Manager/commit/d67b493d30c6483ded4d265d7d51c30924a26739"
 moz-do-not-send="true">https://github.com/inex/IXP-Manager/commit/d67b493d30c6483ded4d265d7d51c30924a26739</a>
        <br></blockquote>
      <br>
      Nick<br>
      <br></blockquote>

  


  <br>
  <fieldset class="mimeAttachmentHeader"></fieldset>
  <br>
  <pre wrap="">_______________________________________________
INEX IXP Manager mailing list
<a class="moz-txt-link-abbreviated" href="mailto:ixpmanager@inex.ie">ixpmanager@inex.ie</a>
Unsubscribe or change options here: <a class="moz-txt-link-freetext" href="https://www.inex.ie/mailman/listinfo/ixpmanager">https://www.inex.ie/mailman/listinfo/ixpmanager</a>
</pre>
</blockquote>
<br>
</body></html>