[ixpmanager] Diff (just for reference) of site-specific tweaks for compare-prefix tool

Rowan Thorpe rowan at rowanthorpe.com
Fri May 29 09:27:27 IST 2015

I am just emailing the attached git-diff here for reference - and it should
obviously not be part of a pull-request - as it includes the site-specific
tweaks I had to make to the hardcoded bits in the compare-prefixes perl-script
for it to work with our (skinned) bird-configs. I send it purely as a helpful
reference for you when you either:

 1. abstract some hardcoded stuff into configurable strings/variables if you
    even want to apply that effort for this perl script

 2. more quickly spot the bits that need abstracting when rewriting in PHP

Also, I realise there is an arbitrary line-in-the-sand at which you choose not
to accomodate every config-style under the sun, and instead require uniform
formatting in the templates - so that diff is useful only inasfar as you want
it to be. The diff applies on top of the two minor commits I just
pull-requested on github (in case you have conflicts when test-applying it on
the present master, that is why).

FWIW: Another gotcha I hit was that because we email ourselves diffs of
bird-config changes from a cronjob for easy visual reference/history, we had
multiple-line prefix-lists (with trailing comments) in our bird-configs for
readability (to avoid mega-long diff-lines). To make this script work we had to
change them to single lines to fit the `while (<LINE>) { regex }` logic, at the
cost of readability of our diff-emails.

Rowan Thorpe
Please avoid sending Word, PowerPoint or Excel attachments
 See http://www.gnu.org/philosophy/no-word-attachments.html
"There is a great difference between worry and concern. A worried person sees
a problem, and a concerned person solves a problem."
 - Harold Stephens
Please feel free to correct my Greek when it is wrong, so I can improve.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: site-specific-prefix-tool-changes.diff
Type: text/x-diff
Size: 4248 bytes
Desc: not available
URL: <https://www.inex.ie/pipermail/ixpmanager/attachments/20150529/3ba667b5/attachment.diff>

More information about the ixpmanager mailing list